Commit 6e099415 authored by Joachim Kołodziejski's avatar Joachim Kołodziejski
Browse files

Use urllib.parse.urljoin instead of string concatenation for voting URL generation

parent 8b9f35ba
Loading
Loading
Loading
Loading
+2 −1
Changes for voters/models.py: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ from django.core.exceptions import ValidationError
from django.core.validators import RegexValidator
from django.conf import settings
from django.urls import reverse
from urllib.parse import urljoin

group_name_validator = RegexValidator(regex=r'^k\d{2}_[a-z]$', message="Nieprawidłowy format nazwy.")

@@ -81,7 +82,7 @@ class Voter(models.Model):
    
    @property
    def voting_url(self):
        return f'{settings.SITE_URL}{reverse('vote:votings', args=[self.token])}' if self.token is not None else None
        return urljoin(settings.SITE_URL, reverse('vote:votings', args=[self.token])) if self.token is not None else None
    
    def has_voted(self, election):
        return self.participation_set.filter(election=election).exists()